fix: move tournament tags css from lakesideview#7538
Open
fikrydev wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves tournament tag theme variables from the Lakesideview skin into this repository so tournament tag styling can be provided directly by Lua-Modules stylesheets.
Changes:
- Removed hardcoded fallback colors from tournament-tag SCSS variables and switched them to rely on CSS custom properties.
- Added per-theme (
theme--light/theme--dark) CSS custom property definitions for tournament tag badge/chip colors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fikrydev
force-pushed
the
fix/move-tournament-tags-css
branch
from
78cfdcd to
f77ea3b
Compare
remove specificity Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
remove specificity Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move all
--tournament-tags-*variables in lakesideview to Lua-Modules.Similar to #7479
How did you test this change?
Preview: Fikry Dev Wiki
Dev Wiki Load Script: Load Script (variables exist here because it was added to lua modules via scss editing on the commons file)
Prod Wiki Load Script: Load Script (the variable doesnt exist here because it's not loaded on the lua modules yet)